Fix OpenBLAS install script avoid GitHub API JSON parsing#4985
Open
weimeng23 wants to merge 2 commits into
Open
Fix OpenBLAS install script avoid GitHub API JSON parsing#4985weimeng23 wants to merge 2 commits into
weimeng23 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves
tools/extras/install_openblas.shby avoiding the GitHub API call used to resolve the OpenBLAS tarball URL.The previous implementation fetched release metadata from the GitHub API and parsed
tarball_urlwith Python:On some environments, especially machines with restricted network access, proxy issues, GitHub API rate limits, or temporary API failures, this command may return empty or non-JSON content. In that case, the script fails with an error like:
Change
Instead of querying the GitHub API, this PR downloads the OpenBLAS release tarball directly from the stable tag archive URL:
https://github.com/OpenMathLib/OpenBLAS/archive/refs/tags/v${OPENBLAS_VERSION}.tar.gzThe script now uses the known
OPENBLAS_VERSIONvalue directly to construct the download URL.Testing
Tested by running:
cd tools bash extras/install_openblas.shBefore this change, the script failed with:
After this change, the script downloads the OpenBLAS tarball directly and proceeds to build/install OpenBLAS successfully.