Fix compilation issues for OpenFST 1.8.4#4984
Open
weimeng23 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an OpenFst build failure in
tools/Makefileby explicitly linking pthread when configuring OpenFst.On some Linux environments, building OpenFst 1.8.4 may fail while linking OpenFst binaries such as
fstepsnormalize, with errors like:These symbols are used through C++ threading primitives, for example
std::shared_mutex, but pthread was not explicitly passed to the OpenFst configure/link step.Change
This PR updates the OpenFst configure command in
tools/Makefileto include pthread flags:Why
-pthreadensures the compiler and linker are both aware of pthread usage, while-lpthreadmakes sure the pthread library is available during the final link step.Without this, OpenFst may compile successfully but fail at the binary linking stage on systems where pthread is not pulled in implicitly.
Testing
Tested by rebuilding OpenFst from a clean state:
cd tools rm -rf openfst openfst-1.8.4 openfst_compiled make openfstAfter this change, OpenFst builds successfully without the unresolved
pthread_rwlock_*references.