Skip to content

Create test report documentation for manual reuse#11

Merged
kako-jun merged 4 commits into
mainfrom
claude/test-report-documentation-01JJiyvFhFVZ4MSFdXevbPrq
Dec 8, 2025
Merged

Create test report documentation for manual reuse#11
kako-jun merged 4 commits into
mainfrom
claude/test-report-documentation-01JJiyvFhFVZ4MSFdXevbPrq

Conversation

@kako-jun

@kako-jun kako-jun commented Dec 8, 2025

Copy link
Copy Markdown
Owner

Pull Request

📋 Summary

Type of Change:

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test improvements

🔗 Related Issues

Fixes #
Relates to #

📝 Changes Made

🧪 Testing

Test Coverage:

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Benchmarks run (if applicable)

Test Results:

# Paste relevant test output here
npm test / cargo test / pytest / etc.

📚 Documentation

  • Code is self-documenting with clear variable/function names
  • Public APIs are documented with /// comments
  • README.md updated (if needed)
  • docs/ updated (if needed)
  • CHANGELOG.md updated (if needed)

✅ Checklist

Before submitting this PR, please ensure:

Code Quality

  • Code follows the project's style guidelines
  • Linting passes (eslint/clippy/flake8/etc.)
  • All tests pass
  • Code builds without warnings

Testing

  • New code has appropriate test coverage
  • All existing tests still pass
  • Edge cases have been considered and tested

Documentation

  • Public APIs are properly documented
  • Complex logic includes inline comments
  • User-facing changes are documented

Breaking Changes

  • Breaking changes are clearly documented
  • Migration guide provided (if applicable)
  • Version bump planned appropriately

🎯 Performance Impact

  • No performance impact
  • Performance improvement (include benchmark results)
  • Potential performance regression (justified by benefits)

Benchmark Results (if applicable):

# Include before/after benchmark results
npm run bench / cargo bench / pytest-benchmark / etc.

🔍 Reviewer Notes

Focus Areas:

Questions for Reviewers:

📸 Screenshots (if applicable)

🚀 Deployment Notes

  • No special deployment requirements
  • Requires configuration changes
  • Requires data migration
  • Other:

By submitting this PR, I confirm that:

  • I have read and followed the Contributing Guidelines
  • My code follows the project's coding standards
  • I have tested my changes thoroughly
  • I understand this will be released under the MIT License

Introduce trycmd-based testing that serves dual purposes:
1. Automated regression testing for CLI behavior
2. Living documentation with real input/output examples

The Markdown files in tests/examples/ can be directly used
in user documentation (mdBook, etc.) as they contain
actual command outputs verified by tests.
Living documentation files are now in docs/examples/ where they
belong as user-facing documentation. Tests still verify them via
trycmd from diffx-cli/tests/examples.rs.
- Add --completions option to generate shell completions (bash, zsh, fish, powershell)
- Add build.rs to generate man page at build time
- Update docs/examples to reflect new CLI options

Usage:
  diffx --completions bash > ~/.local/share/bash-completion/completions/diffx
  diffx --completions zsh > ~/.zfunc/_diffx
- Add shell completions section with installation commands for bash/zsh/fish/powershell
- Add man page installation instructions
- Add link to docs/examples/ (living documentation)
@kako-jun kako-jun merged commit 2555bc3 into main Dec 8, 2025
1 check failed
@kako-jun kako-jun deleted the claude/test-report-documentation-01JJiyvFhFVZ4MSFdXevbPrq branch December 8, 2025 03:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread diffx-cli/Cargo.toml
Comment on lines +32 to +35
[build-dependencies]
clap = { workspace = true }
clap_mangen = "0.2"
clap_complete = "4.5"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire up build script for man/completions generation

A new build script (diffx-cli/build.rs) now writes man pages and shell completions, and you added build-dependencies to support it (lines 32-35), but Cargo.toml still lacks a build = "build.rs" entry in the [package] section. Cargo ignores build scripts unless they are declared, so this script never runs and the documented manpage/completion artifacts will never be generated.

Useful? React with 👍 / 👎.

kako-jun added a commit that referenced this pull request Dec 17, 2025
* feat: add trycmd for living documentation tests

Introduce trycmd-based testing that serves dual purposes:
1. Automated regression testing for CLI behavior
2. Living documentation with real input/output examples

The Markdown files in tests/examples/ can be directly used
in user documentation (mdBook, etc.) as they contain
actual command outputs verified by tests.

* refactor: move example docs to docs/examples/

Living documentation files are now in docs/examples/ where they
belong as user-facing documentation. Tests still verify them via
trycmd from diffx-cli/tests/examples.rs.

* feat: add shell completions and man page generation

- Add --completions option to generate shell completions (bash, zsh, fish, powershell)
- Add build.rs to generate man page at build time
- Update docs/examples to reflect new CLI options

Usage:
  diffx --completions bash > ~/.local/share/bash-completion/completions/diffx
  diffx --completions zsh > ~/.zfunc/_diffx

* docs: update README_ja.md with shell completions and man page

- Add shell completions section with installation commands for bash/zsh/fish/powershell
- Add man page installation instructions
- Add link to docs/examples/ (living documentation)

---------

Co-authored-by: Claude <noreply@anthropic.com>
kako-jun added a commit that referenced this pull request Dec 17, 2025
* feat: add trycmd for living documentation tests

Introduce trycmd-based testing that serves dual purposes:
1. Automated regression testing for CLI behavior
2. Living documentation with real input/output examples

The Markdown files in tests/examples/ can be directly used
in user documentation (mdBook, etc.) as they contain
actual command outputs verified by tests.

* refactor: move example docs to docs/examples/

Living documentation files are now in docs/examples/ where they
belong as user-facing documentation. Tests still verify them via
trycmd from diffx-cli/tests/examples.rs.

* feat: add shell completions and man page generation

- Add --completions option to generate shell completions (bash, zsh, fish, powershell)
- Add build.rs to generate man page at build time
- Update docs/examples to reflect new CLI options

Usage:
  diffx --completions bash > ~/.local/share/bash-completion/completions/diffx
  diffx --completions zsh > ~/.zfunc/_diffx

* docs: update README_ja.md with shell completions and man page

- Add shell completions section with installation commands for bash/zsh/fish/powershell
- Add man page installation instructions
- Add link to docs/examples/ (living documentation)

---------

Co-authored-by: Claude <noreply@anthropic.com>
kako-jun added a commit that referenced this pull request Dec 17, 2025
* feat: add trycmd for living documentation tests

Introduce trycmd-based testing that serves dual purposes:
1. Automated regression testing for CLI behavior
2. Living documentation with real input/output examples

The Markdown files in tests/examples/ can be directly used
in user documentation (mdBook, etc.) as they contain
actual command outputs verified by tests.

* refactor: move example docs to docs/examples/

Living documentation files are now in docs/examples/ where they
belong as user-facing documentation. Tests still verify them via
trycmd from diffx-cli/tests/examples.rs.

* feat: add shell completions and man page generation

- Add --completions option to generate shell completions (bash, zsh, fish, powershell)
- Add build.rs to generate man page at build time
- Update docs/examples to reflect new CLI options

Usage:
  diffx --completions bash > ~/.local/share/bash-completion/completions/diffx
  diffx --completions zsh > ~/.zfunc/_diffx

* docs: update README_ja.md with shell completions and man page

- Add shell completions section with installation commands for bash/zsh/fish/powershell
- Add man page installation instructions
- Add link to docs/examples/ (living documentation)

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants