refactor(ffmpeg): use pyav ffmpeg instead of own version#236
refactor(ffmpeg): use pyav ffmpeg instead of own version#236mutlusun wants to merge 1 commit intokaixxx:mainfrom
Conversation
This commit introduces a new audio conversion tool that uses pyav to convert audio files to the wave format. pyav bundles it's own version of ffmpeg, thus, we don't need to ship our own (outdated) version. In addition, pyav is already a dependency of faster-whisper, thus no real new dependencies are introduced.
|
Maybe it's best to merge #230 before, so tests can run properly. |
|
Hey Rudi, @gernophil: I've tested the code (#280) on my Mac Mini, and it works fine. But I am not sure how to test if we can really get away without Rosetta in this case. We still need Rosetta for ffmpeg in the Editor anyway. But we could switch to PyAV there too. |
|
I'll try that later today. Seems like by starting it using it should not be able to use Rosetta2 even, if it's installed |
Thanks for your feedback! Sorry, I thought, I had edits allowed by maintainers but not sure, maybe I forgot it. It's fine for me, if you merge #280. thanks for testing and merging! :) |
This would be great, if the whole of noScribe on macOS is Rosetta-free. I think this would be the most user-friendly solution. With the release of macOS 27, Rosetta will also be gone from macOS. Would this be an easy addition now that the 'main app' has already switched to PyAV @kaixxx @gernophil ? |
This PR introduces a new audio conversion module that uses pyav to convert audio files to the wave format. pyav bundles it's own version of ffmpeg, thus, we don't need to ship our own (outdated) version. In addition, pyav is already a dependency of faster-whisper, thus no real new dependencies are introduced.
This has the following advantage:
Tested the current changes with:
Unfortunately, I couldn't test whether cancelling an audio file conversion works properly. Conversion was so fast, that I never managed to press fast enough "cancel". Maybe you have a long enough audio file to test that?
Maybe it's safer to merge this after the new release. This way, the changes can be tested over a longer time.