Skip to content
This repository was archived by the owner on Jan 17, 2022. It is now read-only.

Fix ApiServerClient factory#565

Open
ashceo wants to merge 1 commit into
k911:developfrom
dotdevlegacy:develop
Open

Fix ApiServerClient factory#565
ashceo wants to merge 1 commit into
k911:developfrom
dotdevlegacy:develop

Conversation

@ashceo

@ashceo ashceo commented Dec 2, 2021

Copy link
Copy Markdown

In Symfony 5.4 factory format is wrong. Should be "::" not ":"

    K911\Swoole\Server\Api\ApiServerClient:
        factory: K911\Swoole\Server\Api\ApiServerClientFactory:newClient
    K911\Swoole\Server\Api\ApiServerClient:
        factory: K911\Swoole\Server\Api\ApiServerClientFactory::newClient

@ashceo ashceo requested a review from k911 as a code owner December 2, 2021 02:44
@k911

k911 commented Dec 12, 2021

Copy link
Copy Markdown
Owner

Hi @dotdevq, just wanted to inform you that your commit message currently fails validation. Please see contributing guide

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants