This repository was archived by the owner on Jan 17, 2022. It is now read-only.
feat(hmr): use custom binary build with go and fsnotify lib to provide better HMR experience#414
Open
k911 wants to merge 1 commit into
Open
feat(hmr): use custom binary build with go and fsnotify lib to provide better HMR experience#414k911 wants to merge 1 commit into
k911 wants to merge 1 commit into
Conversation
k911
added
kind/feature
k911
force-pushed
the
feat/fsnotify-hmr
branch
2 times, most recently
from
7536cae to
fbefb1d
Compare
k911
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #414 +/- ##
=============================================
- Coverage 85.69% 81.60% -4.10%
- Complexity 644 663 +19
=============================================
Files 91 92 +1
Lines 2041 2125 +84
=============================================
- Hits 1749 1734 -15
- Misses 292 391 +99
|
k911
force-pushed
the
feat/fsnotify-hmr
branch
2 times, most recently
from
22f258b to
bd2520a
Compare
…e better HMR experience
k911
force-pushed
the
feat/fsnotify-hmr
branch
from
bd2520a to
c58002c
Compare
|
Code Climate has analyzed commit c58002c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 31.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 81.5% (-4.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS it is required to check open file limits to make this work:
(See: https://github.com/fsnotify/fsnotify#faq and fsnotify/fsnotify#129)
To fix errors
too many open fileson macOS run:ulimit -n 2048