Use hostname instead of label to query node readiness#1041
Merged
kke merged 2 commits intok0sproject:mainfrom Mar 10, 2026
Merged
Use hostname instead of label to query node readiness#1041kke merged 2 commits intok0sproject:mainfrom
kke merged 2 commits intok0sproject:mainfrom
Conversation
kke
changed the title
There was a problem hiding this comment.
Pull request overview
This PR addresses #1040 by changing the node readiness check to query a node by its name (hostname) instead of using a label selector, avoiding scenarios where the kubelet identity lacks RBAC permissions to list nodes by label.
Changes:
- Switch
kubectl get nodeinvocation from-l kubernetes.io/hostname=...toget node <hostname>. - Update the JSON parsing struct and readiness condition traversal to match the single-Node JSON shape instead of a NodeList.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: gknw <64784493+gknw@users.noreply.github.com>
gknw
force-pushed
the
get-specific-node-instead-of-label-filtering-#1040
branch
from
65a3d3d to
5f9ff8f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed unnecessary node hostname lowercasing Signed-off-by: gknw <64784493+gknw@users.noreply.github.com>
kke
approved these changes
Mar 10, 2026
This was referenced Mar 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #1040 by changing the node readiness check to query a node by its name (hostname) instead of using a label selector, avoiding scenarios where the kubelet identity lacks RBAC permissions to list nodes by label.
Changes:
Switch kubectl get node invocation from -l kubernetes.io/hostname=... to get node .
Update the JSON parsing struct and readiness condition traversal to match the single-Node JSON shape instead of a NodeList.