Skip to content

Refactor optional parameters to use None defaults #40#41

Merged
jvoss merged 2 commits intojvoss:masterfrom
Peter-The-Great:api-extra-fields-fix
Mar 26, 2026
Merged

Refactor optional parameters to use None defaults #40#41
jvoss merged 2 commits intojvoss:masterfrom
Peter-The-Great:api-extra-fields-fix

Conversation

@Peter-The-Great
Copy link
Copy Markdown
Contributor

@Peter-The-Great Peter-The-Great commented Mar 25, 2026

This is to fix the #40 issue that I have with this library. This change could significantly help the application, just incase RIPE starts adding more fields to their results that will not yet be indexed by this library.

@jvoss
Copy link
Copy Markdown
Owner

jvoss commented Mar 25, 2026

@Peter-The-Great thanks! I need to spend some time refactoring a lot of this use more modern tools as well.

Pydantic would probably make a much better fit here in general too.

@Peter-The-Great
Copy link
Copy Markdown
Contributor Author

Peter-The-Great commented Mar 25, 2026

That's totally up to you man, this was the only issue I had. And it works for me now on my fork. I wanted to use it in another project, but wasn't sure how long it would take to get a response. Thanks for the message!

@jvoss
Copy link
Copy Markdown
Owner

jvoss commented Mar 25, 2026

That's totally up to you man, this was the only issue I had. And it works for me now on my fork. I wanted to use it in another project, but wasn't sure how long it would take to get a response. Thanks for the message!

All good. It's been a minute since I've dusted this off. I will work through getting the tests working again in general too. Thanks for the PR!

@jvoss jvoss force-pushed the api-extra-fields-fix branch from 4c99ea5 to ca196c9 Compare March 25, 2026 17:19
@jvoss
Copy link
Copy Markdown
Owner

jvoss commented Mar 26, 2026

Tests pass other than coverage for 1 line. Merging to take the contribution and fix in the future.

@jvoss jvoss merged commit af21f15 into jvoss:master Mar 26, 2026
8 of 15 checks passed
@Peter-The-Great Peter-The-Great deleted the api-extra-fields-fix branch March 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants