Refactor optional parameters to use None defaults #40#41
Conversation
|
@Peter-The-Great thanks! I need to spend some time refactoring a lot of this use more modern tools as well. Pydantic would probably make a much better fit here in general too. |
|
That's totally up to you man, this was the only issue I had. And it works for me now on my fork. I wanted to use it in another project, but wasn't sure how long it would take to get a response. Thanks for the message! |
All good. It's been a minute since I've dusted this off. I will work through getting the tests working again in general too. Thanks for the PR! |
This is to fix the jvoss#40 issue that i have with this api.
4c99ea5 to
ca196c9
Compare
|
Tests pass other than coverage for 1 line. Merging to take the contribution and fix in the future. |
This is to fix the #40 issue that I have with this library. This change could significantly help the application, just incase RIPE starts adding more fields to their results that will not yet be indexed by this library.