feat(website): add browser play and locale support (#127)#388
feat(website): add browser play and locale support (#127)#388jasperan wants to merge 3 commits intojvondermarck:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Code Formatting Check Passed!Great job! 🎉 Your code follows the Google Java Style Guide. 🤖 The DinoBot Team 🦖 |
There was a problem hiding this comment.
👋 Hello @jasperan, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with the repository
/dinosaur-explodermainbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
- ✅ Verify that you have well fill out the different checkboxes in the PR template.
⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.- 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
Build preview 🚀Thanks for your contribution to this open-source project! ❤️ A new build has been generated for this pull request:
Tip This JAR lets you test the latest version of the game from this PR. ⏳ Note: Artifacts auto-expire after ~90 days. Happy testing & enjoy the game! 🎮 The DinoBot Team 🦖 |
|
Hey @jasperan, I saw there is a compile error: Can you check this? |
|
Yes @jvondermarck let me take a look, apologies. |
IBM Plex Mono does not include a greek subset, causing a Next.js build failure. Removed it from the subsets array to fix compilation.
|
I believe removing greek subset lettering fixed the compilation issue. can you verify @jvondermarck ? |
|
Hey, in fact I tried now, the "Play" page is a bit of a misunderstood for the user, as we think the controls at the right are the one of the web game. Plus this tiny web game, was just a fun way to have like the "dino" game when we have a 404 page on Google. It's not the real game, so maybe we could be even more clear: say a bit like you wrote, but saying this tiny web game is NOT the official game, it's just small example, so there should be FIRST a link to the release page of Github to download the game / the README documentation on how to install it (point the README link to the correct title link). And then you can try to find a way explaining that you can find bellow a web implement dino game that is NOT the real game, just something to have fun while the REAL game is downloading on the user PC... I don't know if it's clear... Otherwise tell me |
|
Hey @jasperan I merged a PR where it added a french new language, please merge the main branch in your branch to resolve conflicts. Sorry for the inconvenience. Anyway, good luck and let me know if you struggle on something :) |
Resolve the French locale merge, clarify the Play page as an unofficial browser demo, and point users to the official download and install docs first.
|



Summary
/{lang}/playroute so the browser build is no longer buried on the 404 pageRelated Issues
Closes #127
Closes #301
Closes #313
Closes #348
Closes #349
Verification
npm test -- --runInBandnpm run lintnpm run build