Skip to content

feat(website): add browser play and locale support (#127)#388

Open
jasperan wants to merge 3 commits intojvondermarck:mainfrom
jasperan:pr/website-browser-play-i18n
Open

feat(website): add browser play and locale support (#127)#388
jasperan wants to merge 3 commits intojvondermarck:mainfrom
jasperan:pr/website-browser-play-i18n

Conversation

@jasperan
Copy link
Copy Markdown
Contributor

@jasperan jasperan commented Apr 4, 2026

Summary

  • add a dedicated /{lang}/play route so the browser build is no longer buried on the 404 page
  • expand the website locales with Spanish and Russian
  • add locale-aware font fallbacks so Cyrillic text renders cleanly
  • improve localized metadata and add an in-site review/feedback path

Related Issues

Closes #127
Closes #301
Closes #313
Closes #348
Closes #349

Verification

  • npm test -- --runInBand
  • npm run lint
  • npm run build

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dinosaur-exploder Ready Ready Preview, Comment Apr 16, 2026 0:13am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

✅ Code Formatting Check Passed!

badge

Great job! 🎉 Your code follows the Google Java Style Guide.


🤖 The DinoBot Team 🦖

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @jasperan, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
  • ✅ Verify that you have well fill out the different checkboxes in the PR template.
  • ⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.
  • 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

Build preview 🚀

badge

Thanks for your contribution to this open-source project! ❤️

A new build has been generated for this pull request:

  • 🎮 Game Artifacts: 🐧 Linux / 🍎 macOS / 🪟 Windows
  • 🧪 Workflow Run: View Logs
  • 🔖 Commit: ce7dbea1ce9c82456d938b3c7443f61b470dddf1

Tip

This JAR lets you test the latest version of the game from this PR.

Note: Artifacts auto-expire after ~90 days.

Happy testing & enjoy the game! 🎮

The DinoBot Team 🦖

@jvondermarck
Copy link
Copy Markdown
Owner

Hey @jasperan, I saw there is a compile error:

Failed to compile.
./app/[lang]/layout.tsx:65:34
Type error: Type '"greek"' is not assignable to type '"latin" | "cyrillic" | "latin-ext" | "cyrillic-ext" | "vietnamese"'.
  63 |   weight: ["400", "500", "600", "700"],
  64 |   variable: "--font-ibm-plex-mono",
> 65 |   subsets: ["latin", "cyrillic", "greek"],
     |                                  ^
  66 |   display: "swap",
  67 | });
  68 |
Next.js build worker exited with code: 1 and signal: null
Error: Command "npm run build" exited with 1

Can you check this?

@jvondermarck jvondermarck added status: in-review PR currently in review status: pending-request-changes Request changes from the contributor labels Apr 8, 2026
@jasperan
Copy link
Copy Markdown
Contributor Author

jasperan commented Apr 9, 2026

Yes @jvondermarck let me take a look, apologies.

IBM Plex Mono does not include a greek subset, causing a Next.js
build failure. Removed it from the subsets array to fix compilation.
@jasperan
Copy link
Copy Markdown
Contributor Author

jasperan commented Apr 9, 2026

I believe removing greek subset lettering fixed the compilation issue. can you verify @jvondermarck ?

@jvondermarck
Copy link
Copy Markdown
Owner

Hey, in fact I tried now, the "Play" page is a bit of a misunderstood for the user, as we think the controls at the right are the one of the web game.

Plus this tiny web game, was just a fun way to have like the "dino" game when we have a 404 page on Google. It's not the real game, so maybe we could be even more clear: say a bit like you wrote, but saying this tiny web game is NOT the official game, it's just small example, so there should be FIRST a link to the release page of Github to download the game / the README documentation on how to install it (point the README link to the correct title link). And then you can try to find a way explaining that you can find bellow a web implement dino game that is NOT the real game, just something to have fun while the REAL game is downloading on the user PC... I don't know if it's clear... Otherwise tell me

@jvondermarck
Copy link
Copy Markdown
Owner

Hey @jasperan I merged a PR where it added a french new language, please merge the main branch in your branch to resolve conflicts. Sorry for the inconvenience.

Anyway, good luck and let me know if you struggle on something :)

@jvondermarck jvondermarck added the status: pending-conflict-resolution Wait the author to resolve the conflicts before merging label Apr 14, 2026
Resolve the French locale merge, clarify the Play page as an unofficial browser demo, and point users to the official download and install docs first.
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: in-review PR currently in review status: pending-conflict-resolution Wait the author to resolve the conflicts before merging status: pending-request-changes Request changes from the contributor

Projects

2 participants