Skip to content

feat: download remaining old lazy splits on new release failure or timeout #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balaganesh-juspay merged 1 commit into from
Mar 26, 2026
Merged

feat: download remaining old lazy splits on new release failure or timeout #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airborne_sdk_android/airborne/src/main/java/in/juspay/airborne/ota/UpdateTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ internal class UpdateTask(
if (fetched == null) {
// Unable to fetch so exiting.
currentResult = UpdateResult.Error.RCFetchError
shouldDownloadCurLazySplits = true
onComplete(Stage.INSTALLING)
} else {
updateTimeouts(fetched)
Expand Down
148 changes: 107 additions & 41 deletions airborne_sdk_iOS/hyper-ota/Airborne/AirborneObjC/ApplicationManager/AJPApplicationManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,7 @@ - (void)startDownload {
self.lazyPackageDownloadStatus = COMPLETED;
[self cleanUpUnwantedFiles];
[self fireCallbacks];
[self retryFailedLazyDownloads];
}
[[NSNotificationCenter defaultCenter] postNotificationName:RELEASE_CONFIG_NOTIFICATION
object:nil
Expand Down Expand Up @@ -717,55 +718,72 @@ - (void)tryDownloadingUpdate {
if (!downloadFailed) { // Important packages downloaded successfully/No updates.
[strongSelf didFinishImportantPackageWithLazyDownloadComplete:timedOut];

// Start lazy packages download.
NSArray<AJPResource *> *toDownload = [self getResourcesFrom:strongSelf.downloadedLazy filtering:strongSelf.currentLazy];
NSString *packageVersion = timedOut ? strongSelf.downloadedApplicationManifest.package.version : strongSelf.package.version;
[strongSelf downloadLazyPackageResources:toDownload version:packageVersion singleDownloadHandler:^(BOOL status, AJPResource *resource) {
if (!weakSelf) {
return;
}
__strong AJPApplicationManager* strongSelf = weakSelf;
if (timedOut) {

if (timedOut) {
if (!status) {
[strongSelf retryFailedLazyDownloadsWithCompletion:^{
Comment thread
balaganesh-juspay marked this conversation as resolved.
if (!weakSelf) {
return;
}

for (NSUInteger i = 0; i < strongSelf.downloadedLazy.count; i++) {
AJPLazyResource *lazyResource = strongSelf.downloadedLazy[i];
if ([lazyResource.filePath isEqualToString:resource.filePath]) {
lazyResource.isDownloaded = status;
strongSelf.downloadedLazy[i] = lazyResource;
break;
__strong AJPApplicationManager* strongSelf = weakSelf;
NSArray<AJPResource *> *toDownload = [strongSelf getResourcesFrom:strongSelf.downloadedLazy filtering:strongSelf.currentLazy];
NSString *packageVersion = strongSelf.downloadedApplicationManifest.package.version;
[strongSelf downloadLazyPackageResources:toDownload version:packageVersion singleDownloadHandler:^(BOOL status, AJPResource *resource) {
if (!weakSelf) {
return;
}
__strong AJPApplicationManager* strongSelf = weakSelf;

if (!status) {
return;
}

@synchronized(strongSelf.downloadedLazy) {
for (NSUInteger i = 0; i < strongSelf.downloadedLazy.count; i++) {
AJPLazyResource *lazyResource = strongSelf.downloadedLazy[i];
if ([lazyResource.filePath isEqualToString:resource.filePath]) {
lazyResource.isDownloaded = status;
strongSelf.downloadedLazy[i] = lazyResource;
break;
}
}
}
} downloadCompletion:^{
if (!weakSelf) {
return;
}
__strong AJPApplicationManager* strongSelf = weakSelf;

strongSelf.downloadedApplicationManifest.package.lazy = strongSelf.downloadedLazy;
[strongSelf updatePackageInTemp:strongSelf.downloadedApplicationManifest.package];
}];
}];
} else {
NSArray<AJPResource *> *toDownload = [strongSelf getResourcesFrom:strongSelf.downloadedLazy filtering:strongSelf.currentLazy];
NSString *packageVersion = strongSelf.package.version;
[strongSelf downloadLazyPackageResources:toDownload version:packageVersion singleDownloadHandler:^(BOOL status, AJPResource *resource) {
if (!weakSelf) {
return;
}
return;
}

if (status) { // Download success
// Move downloaded lazy package to main.
AJPLazyResource *lazyResource = (AJPLazyResource *)resource;
[strongSelf moveLazyPackageFromTempToMain:lazyResource];
}
[[NSNotificationCenter defaultCenter] postNotificationName:LAZY_PACKAGE_NOTIFICATION object:nil userInfo:@{@"lazyDownloadsComplete": @NO, @"downloadStatus": @(status), @"url": resource.url, @"filePath": resource.filePath}];
} downloadCompletion:^{
if (!weakSelf) {
return;
}
__strong AJPApplicationManager* strongSelf = weakSelf;

if (timedOut) {
strongSelf.downloadedApplicationManifest.package.lazy = strongSelf.downloadedLazy;
[strongSelf updatePackageInTemp:strongSelf.downloadedApplicationManifest.package];
__strong AJPApplicationManager* strongSelf = weakSelf;

return;
}

[[NSNotificationCenter defaultCenter] postNotificationName:LAZY_PACKAGE_NOTIFICATION object:nil userInfo:@{@"lazyDownloadsComplete": @YES}];
}];
if (status) { // Download success
// Move downloaded lazy package to main.
AJPLazyResource *lazyResource = (AJPLazyResource *)resource;
[strongSelf moveLazyPackageFromTempToMain:lazyResource];
}
[[NSNotificationCenter defaultCenter] postNotificationName:LAZY_PACKAGE_NOTIFICATION object:nil userInfo:@{@"lazyDownloadsComplete": @NO, @"downloadStatus": @(status), @"url": resource.url, @"filePath": resource.filePath}];
} downloadCompletion:^{
if (!weakSelf) {
return;
}
__strong AJPApplicationManager* strongSelf = weakSelf;

[[NSNotificationCenter defaultCenter] postNotificationName:LAZY_PACKAGE_NOTIFICATION object:nil userInfo:@{@"lazyDownloadsComplete": @YES}];
}];
}
} else {
// Don't download lazy pacakge if important pacakge download failed.
[strongSelf didFinishImportantPackageWithLazyDownloadComplete:YES];
[strongSelf retryFailedLazyDownloads];
}
}
}];
Expand Down Expand Up @@ -1326,6 +1344,54 @@ - (void)retryFailedLazyDownloads {
}
}

- (void)retryFailedLazyDownloadsWithCompletion:(void (^)(void))completion {
NSMutableArray<AJPLazyResource *> *failedDownloads = [NSMutableArray array];

// Find all lazy resources that are marked as not downloaded
@synchronized(self.package) {
for (AJPLazyResource *resource in self.package.lazy) {
if (!resource.isDownloaded) {
[failedDownloads addObject:resource];
}
}
}

if (failedDownloads.count > 0) {
[self.tracker trackInfo:@"retrying_failed_lazy_downloads" value:[@{@"count": @(failedDownloads.count)} mutableCopy]];

__weak AJPApplicationManager *weakSelf = self;
[self downloadLazyPackageResources:failedDownloads version:self.package.version singleDownloadHandler:^(BOOL status, AJPResource *resource) {
if (status && [resource isKindOfClass:[AJPLazyResource class]]) {
if (weakSelf) {
__strong AJPApplicationManager* strongSelf = weakSelf;
AJPLazyResource *lazyResource = (AJPLazyResource *)resource;
[strongSelf moveLazyPackageFromTempToMain:lazyResource];
}
}
[[NSNotificationCenter defaultCenter] postNotificationName:LAZY_PACKAGE_NOTIFICATION
object:nil
userInfo:@{
@"lazyDownloadsComplete": @NO,
@"downloadStatus": @(status),
@"url": resource.url,
@"filePath": resource.filePath
}];
} downloadCompletion:^{
[[NSNotificationCenter defaultCenter] postNotificationName:LAZY_PACKAGE_NOTIFICATION
object:nil
userInfo:@{@"lazyDownloadsComplete": @YES}];
if (completion) {
completion();
}
}];
} else {
[self.tracker trackInfo:@"no_failed_lazy_downloads" value:[@{} mutableCopy]];
if (completion) {
completion();
}
}
}

- (void)updatePackage:(AJPApplicationPackage *)package didDownloadImportant:(BOOL)didDownloadImportant startTime:(NSTimeInterval)startTime {
NSError *error = nil;
[self.tracker trackInfo:@"app_update_result" value:[@{@"trying_to_install_package": [NSString stringWithFormat:@"New app version downloaded, installing to disk. %@", package.version]}mutableCopy]];
Expand Down
Loading