Fix bind method to return correct index.#144
Open
snesin wants to merge 3 commits intojupiterjs:masterfrom
snesin:master
Open
Fix bind method to return correct index.#144snesin wants to merge 3 commits intojupiterjs:masterfrom snesin:master
snesin wants to merge 3 commits intojupiterjs:masterfrom
snesin:master
Conversation
bind method is supposed to return index in _bindings, not length of _bindings afterwards.
Add drag.perpetuate method, allowing multiple drops or rejected drops to force additional dragging.
Add drag.perpetuate method, allowing multiple drops or rejected drops to force additional dragging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was returning length of _bindings after adding instead of the index at which it was added.