Fix two stopwatch NPEs (Reset-before-Start, Stop-before-Start)#8
Merged
Conversation
- CircularTimerView.stop(): guard timerTask before cancel(). reset() calls stop() before any start(), but timerTask is null until start() — so hitting Reset before Start crashed with a NullPointerException. - TimerActivity: pressing Stop before Start left start_time null, and the interval formatting then NPE'd on sdf.format(null). Skip recording when there is no start time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two real
NullPointerExceptioncrashes in the study-timer, found reading the timer code line-by-line:CircularTimerView.stop()dereferencedtimerTaskunconditionally.reset()callsstop(), andtimerTaskisnulluntilstart()is first called — so pressing Reset before Start crashed. Guarded thecancel()with a null check.TimerActivityStop-before-Start. Pressing Stop before Start leftstart_time == null, and the interval logging then calledsdf.format(null)→ NPE. Skip recording when there is no start time.Both are minimal guards with no change to the normal start→stop→reset path. (No Gradle build available in CI here, so reasoned from source.)
Generated by Claude Code