improve: overhaul setup-docker.sh with env vars, dry-run, daemon mgmt, better idempotency#1
Open
hermes-denkobot wants to merge 1 commit into
Open
Conversation
…, better idempotency - Add 8 environment variable overrides - Add --dry-run flag - Docker daemon start/enable via systemctl - Faster verification (replaced hello-world with --version checks) - Better idempotency (dpkg-query, GPG key validation, repo list check) - Docker daemon.json with log rotation defaults - --no-install-recommends for minimal installs - Version pinning support via DOCKER_PACKAGES_VERSION - Custom mirror support - Replaced lsb_release with /etc/os-release parsing - Full component verification (Docker, containerd, Compose, Buildx)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhauled
setup-docker.shwith significant improvements:New Environment Variables (8 total)
DOCKER_APT_KEY_URL,DOCKER_KEY_PATH,DOCKER_LIST_PATH,DOCKER_REPO_URL— custom pathsDOCKER_PACKAGES— custom package listDOCKER_PACKAGES_VERSION— version pinning for reproducible installsDOCKER_MIRROR— custom mirror supportDOCKER_ENABLE_SERVICE— auto-start Docker daemonNew Features
--dry-runflag — preview modesystemctl enable --now dockerDOCKER_PACKAGES_VERSIONBug Fixes
lsb_releasewith/etc/os-releaseparsing (works on minimal installs)docker run hello-world— replaced with instantdocker --versioncheckssg dockeralternativeReliability
dpkg-queryinstead ofdpkg -lfor reliable package detection--no-install-recommendsfor minimal installs