Skip to content

Bump github.com/rs/cors from 1.9.0 to 1.11.0 in /api#60

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/api/github.com/rs/cors-1.11.0
Open

Bump github.com/rs/cors from 1.9.0 to 1.11.0 in /api#60
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/go_modules/api/github.com/rs/cors-1.11.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jul 5, 2024

Bumps github.com/rs/cors from 1.9.0 to 1.11.0.

Commits
  • 4c32059 Normalize allowed request headers and store them in a sorted set (fixes #170)...
  • 8d33ca4 Complete documentation; deprecate AllowOriginRequestFunc in favour of AllowOr...
  • af821ae Merge branch 'jub0bs-master'
  • 0bcf73f Update benchmark
  • eacc8e8 Fix skewed middleware benchmarks (#165)
  • 9297f15 Respect the documented precedence of options (#163)
  • 73f81b4 Fix readme benchmark rendering (#161)
  • e19471c Prevent empty Access-Control-Expose-Headers header (#160)
  • 20a76bd Update benchmark
  • 46855ae Remove travis build report from README
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [github.com/rs/cors](https://github.com/rs/cors) from 1.9.0 to 1.11.0.
- [Commits](rs/cors@v1.9.0...v1.11.0)

---
updated-dependencies:
- dependency-name: github.com/rs/cors
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 5, 2024
Copy link
Copy Markdown

@itaconstrucciones0001-wq itaconstrucciones0001-wq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Osha01

@julsemaan
Copy link
Copy Markdown
Owner

[Severity: Major] [Confidence: High]

Location: api/go.mod:10

Issue: This Dependabot PR is also upgrading github.com/rs/rest-layer from a 2016 pseudo-version to v0.2.0, even though the PR title/body imply a narrow rs/cors bump.

Why it matters: rest-layer is a direct dependency used in the API handler/resource wiring (api/internal/app/run.go, api/internal/resources/index.go), so this changes request-processing behavior in the hot path and could introduce runtime regressions that aren't covered by this PR.

Suggested fix: Either pin github.com/rs/rest-layer back to the currently reviewed version for this PR, or split that upgrade into a separate PR with focused regression coverage (at minimum go test ./... plus an API smoke/integration test around resource binding and insert hooks).

Copy link
Copy Markdown
Owner

@julsemaan julsemaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall assessment: This PR looks low-risk for the github.com/rs/cors portion, but it also upgrades the direct github.com/rs/rest-layer dependency. That makes the effective change broader than the PR title/body suggest and raises API/runtime regression risk.
Risk level: Medium

Critical issues:

  • None.

Major issues:

  • api/go.mod also moves github.com/rs/rest-layer from v0.0.0-20160505213648-cb84bc79b5b8 to v0.2.0. I left a location-specific comment because this dependency is used directly in the API handler/resource setup.
  • There are no successful PR checks attached here (check_runs: 0, combined status still pending), so this direct dependency change is not currently backed by automated validation.

Minor issues:

  • None.

DRY improvement opportunities:

  • None specific to this diff.

Suggested next steps:

  1. Re-pin github.com/rs/rest-layer for this PR, or split that upgrade into its own PR.
  2. Run and attach go test ./... results, plus a small API smoke/integration test around resource binding and insert hooks before merging the rest-layer change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants