bug-fix: ofxFlashMatrix set_y_scale had the sin positive.#4
Open
jesusgollonet wants to merge 1 commit intojulapy:masterfrom
jesusgollonet:flash-matrix-fix
Open
bug-fix: ofxFlashMatrix set_y_scale had the sin positive.#4jesusgollonet wants to merge 1 commit intojulapy:masterfrom jesusgollonet:flash-matrix-fix
jesusgollonet wants to merge 1 commit intojulapy:masterfrom
jesusgollonet:flash-matrix-fix
Conversation
…ght and rotating at the same time gave weird transformation problems
Owner
|
nice find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem: rotating a sprite while altering its height gave weird transformation problems. width was fine
to test
with the fix we get the expected result, a box that is growing vertically and rotates at the same time
the problem was that in set_y_scale, setC wasn't using the sin as negative.