call $controller->commit() outside of foreach loop#27
Open
lyrapet wants to merge 1 commit intojtl-software:masterfrom
Open
call $controller->commit() outside of foreach loop#27lyrapet wants to merge 1 commit intojtl-software:masterfrom
$controller->commit() outside of foreach loop#27lyrapet wants to merge 1 commit intojtl-software:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit b3b00eb broke the
TransactionalInterfaceController handling. It starts the transaction with$controller->beginTransaction()at the beginning, calls the$controller->commit()however multiple times inside theforeachloop which should only happen once at the end of thetry...catchblock because you can't commit a transaction more than once. This will throw if more than 1 model has been passed to a Controller which implements theTransactionalInterface.