Skip to content

fix SDO unit tests for param flags UID change #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsphuebner merged 1 commit into from
Apr 30, 2026
Merged

fix SDO unit tests for param flags UID change #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/test_cansdo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ static void sdo_read_strings_initiates_print_request()
static void sdo_read_param_flags_default()
{
// By default flags are FLAG_NONE (0)
SendSdoRequest(SDO_READ, 0x2200, Param::ocurlim, 0);
SendSdoRequest(SDO_READ, 0x2200, Param::GetAttrib(Param::ocurlim)->id, 0);

ASSERT(canStub->m_canId == SdoRepId);
ASSERT(GetReply()->cmd == SDO_READ_REPLY);
Expand All @@ -483,14 +483,14 @@ static void sdo_read_param_flags_default()
static void sdo_write_and_read_param_flags()
{
// Set FLAG_HIDDEN on ocurlim
SendSdoRequest(SDO_WRITE, 0x2200, Param::ocurlim, (uint32_t)Param::FLAG_HIDDEN);
SendSdoRequest(SDO_WRITE, 0x2200, Param::GetAttrib(Param::ocurlim)->id, (uint32_t)Param::FLAG_HIDDEN);

ASSERT(canStub->m_canId == SdoRepId);
ASSERT(GetReply()->cmd == SDO_WRITE_REPLY);
ASSERT(Param::GetFlag(Param::ocurlim) == Param::FLAG_HIDDEN);

// Read it back
SendSdoRequest(SDO_READ, 0x2200, Param::ocurlim, 0);
SendSdoRequest(SDO_READ, 0x2200, Param::GetAttrib(Param::ocurlim)->id, 0);
ASSERT(GetReply()->cmd == SDO_READ_REPLY);
ASSERT(GetReply()->data == (uint32_t)Param::FLAG_HIDDEN);
}
Expand All @@ -499,7 +499,7 @@ static void sdo_write_param_flags_clear()
{
// Pre-set the flag, then clear it via SDO
Param::SetFlag(Param::ocurlim, Param::FLAG_HIDDEN);
SendSdoRequest(SDO_WRITE, 0x2200, Param::ocurlim, (uint32_t)Param::FLAG_NONE);
SendSdoRequest(SDO_WRITE, 0x2200, Param::GetAttrib(Param::ocurlim)->id, (uint32_t)Param::FLAG_NONE);

ASSERT(canStub->m_canId == SdoRepId);
ASSERT(GetReply()->cmd == SDO_WRITE_REPLY);
Expand Down
Loading