Fix ?? operator with array predicate on LHS#774
Merged
andrew-coleman merged 1 commit intojsonata-js:masterfrom Mar 18, 2026
Merged
Conversation
The ?? infix handler reused the same `left` AST node reference for both the $exists() condition and the `then` branch. During AST post-processing, filter stages were pushed onto the shared node twice, turning e.g. `array[1]` into `array[1][1]`. Deep-clone `left` for the condition argument so the two branches have independent AST nodes. Fixes jsonata-js#773
andrew-coleman
approved these changes
Mar 18, 2026
Member
|
Many thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
??(nullish coalescing) operator returning incorrect results when the LHScontains an array predicate (e.g.
array[1] ?? 3)??handler reused the sameleftAST node reference for both the$exists()condition and thethenbranch, causing filter stages to be duplicatedduring AST post-processing
leftfor the condition argument so the two branches have independentAST nodes
Fixes #773
Test plan
Signed-off-by: Jolse Maginnis doolse@gmail.com