proper placement for recently added function signature tests#771
Open
mikhail-barg wants to merge 1 commit intojsonata-js:masterfrom
Open
proper placement for recently added function signature tests#771mikhail-barg wants to merge 1 commit intojsonata-js:masterfrom
mikhail-barg wants to merge 1 commit intojsonata-js:masterfrom
Conversation
Member
|
Hi @mikhail-barg - apologies, I just noticed after moving the tests that you'd raised this PR to do the same a while back. My bad! |
Author
|
@andrew-coleman done! |
Comment on lines
1050
to
1057
| if (rest.type === 'function' && | ||
| rest.procedure.type === 'path' && | ||
| rest.procedure.steps.length === 1 && | ||
| rest.procedure.steps[0].type === 'name' && | ||
| result.steps[result.steps.length - 1].type === 'function') { | ||
| // next function in chain of functions - will override a thenable | ||
| result.steps[result.steps.length - 1].nextFunction = rest.procedure.steps[0].value; | ||
| } |
Member
There was a problem hiding this comment.
You'll need to take out the whole if block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also a minor fix removing unused
nextFunctionattributeFixes #769