docs(settings): update Developer Mode copy to reflect terminal tabs#82
Merged
jsgrrchg merged 1 commit intoMay 12, 2026
Merged
Conversation
The Settings copy under Developer Mode still describes the integrated terminal as a "bottom developer terminal panel," but the current implementation opens terminals as editor/workspace tabs via "New Terminal." Update both the "Enable Developer Mode" and "Enable Integrated Terminal" descriptions (and their search-match counterparts) to use the tab-based wording suggested in jsgrrchg#37. Closes jsgrrchg#37
Owner
|
Hi! Thanks you for your PR. I really appreciate you staying in the AI loop, even for small changes. With so much unreviewed AI generated code being pushed these days, that kind of care really matters. I'll merge now, already reviewed. 0.2.5 is already out, have some fun, there a lot of goodies :) Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #37 noticed that the Settings copy under Developer Mode still describes the integrated terminal as a "bottom developer terminal panel," even though the current implementation opens terminals as editor/workspace tabs (via "New Terminal" mounted into the active pane). This PR updates the four affected description strings in
SettingsPanel.tsxso the copy matches what the user actually sees.Changes
apps/desktop/src/features/settings/SettingsPanel.tsx:Enable Developer Modedescription: "Show experimental developer-facing surfaces such as the integrated terminal." (drops the stale "panel" wording)Enable Integrated Terminaldescription: "Enable terminal tabs in the editor workspace and related commands." (the wording suggested in the issue)Both strings appear twice in the file: once inside
sectionHasSettingsSearchMatches(...)(where they drive Settings-search matching) and once on the matchingSearchableRowprop. All four occurrences are updated so the search behavior and rendered description stay in sync.Verification
The old strings are no longer referenced anywhere else under
apps/desktop/:No tests assert the old copy, so no test changes are required:
I did not run
npm run lint/npm testlocally because this is a pure string change with no logic, type, or test surface touched, and theapps/desktopinstall was skipped to keep the change minimal.Closes #37
AI disclosure: authored with Claude as a coding assistant; I reviewed the change before pushing.