Skip to content

docs(settings): update Developer Mode copy to reflect terminal tabs#82

Merged
jsgrrchg merged 1 commit into
jsgrrchg:mainfrom
mvanhorn:fix/integrated-terminal-settings-copy
May 12, 2026
Merged

docs(settings): update Developer Mode copy to reflect terminal tabs#82
jsgrrchg merged 1 commit into
jsgrrchg:mainfrom
mvanhorn:fix/integrated-terminal-settings-copy

Conversation

@mvanhorn
Copy link
Copy Markdown
Contributor

Summary

Issue #37 noticed that the Settings copy under Developer Mode still describes the integrated terminal as a "bottom developer terminal panel," even though the current implementation opens terminals as editor/workspace tabs (via "New Terminal" mounted into the active pane). This PR updates the four affected description strings in SettingsPanel.tsx so the copy matches what the user actually sees.

Changes

apps/desktop/src/features/settings/SettingsPanel.tsx:

  • Enable Developer Mode description: "Show experimental developer-facing surfaces such as the integrated terminal." (drops the stale "panel" wording)
  • Enable Integrated Terminal description: "Enable terminal tabs in the editor workspace and related commands." (the wording suggested in the issue)

Both strings appear twice in the file: once inside sectionHasSettingsSearchMatches(...) (where they drive Settings-search matching) and once on the matching SearchableRow prop. All four occurrences are updated so the search behavior and rendered description stay in sync.

Verification

The old strings are no longer referenced anywhere else under apps/desktop/:

$ grep -rn "bottom developer terminal\|integrated terminal panel" apps/
(no matches)

No tests assert the old copy, so no test changes are required:

$ grep -n "integrated terminal\|terminal panel\|bottom developer" \
    apps/desktop/src/features/settings/SettingsPanel.test.tsx
(no matches)

I did not run npm run lint / npm test locally because this is a pure string change with no logic, type, or test surface touched, and the apps/desktop install was skipped to keep the change minimal.

Closes #37

AI disclosure: authored with Claude as a coding assistant; I reviewed the change before pushing.

The Settings copy under Developer Mode still describes the integrated
terminal as a "bottom developer terminal panel," but the current
implementation opens terminals as editor/workspace tabs via "New
Terminal." Update both the "Enable Developer Mode" and "Enable
Integrated Terminal" descriptions (and their search-match counterparts)
to use the tab-based wording suggested in jsgrrchg#37.

Closes jsgrrchg#37
@jsgrrchg
Copy link
Copy Markdown
Owner

Hi! Thanks you for your PR. I really appreciate you staying in the AI loop, even for small changes. With so much unreviewed AI generated code being pushed these days, that kind of care really matters.

I'll merge now, already reviewed.

0.2.5 is already out, have some fun, there a lot of goodies :)

Thanks again!

@jsgrrchg jsgrrchg merged commit 78fade7 into jsgrrchg:main May 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrated terminal description in settings doesn't reflect the current terminal tab implementation

2 participants