Fixing Z-Order when duplicating groups#66
Merged
Merged
Conversation
jrupp
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes component z-order inversion that occurred when duplicating/cloning a ComponentGroup, ensuring duplicated groups preserve the original draw order within the LayoutLayer.
Changes:
- Adjusted
LayoutLayer.addChild()insertion logic to increment the insertion index per child so multi-add operations preserve order. - Added a regression test that duplicates a selected group and asserts the cloned components keep the same relative ordering.
- Updated existing group-clone positioning assertions to check relative spacing instead of hard-coded offsets, and updated the documented spec count.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/model/layoutLayer.js | Fixes child insertion order by incrementing the insertion index and updating it after adding a ComponentGroup. |
| spec/support/something.spec.mjs | Adds a z-order regression test for group duplication and makes clone-position tests assert relative spacing. |
| CLAUDE.md | Updates documented Jasmine spec count formatting/count. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bricklayouts.canny.io/feature-requests/p/duplicating-a-group-doesnt-retain-z-order
When a ComponentGroup is duplicated/cloned, the components in it were not maintaining z-order. They would end up in the reverse order.