feat(ui): implement skeleton loaders for market map and leaderboard#67
Draft
Mohammad-Hassan027 wants to merge 3 commits into
Draft
feat(ui): implement skeleton loaders for market map and leaderboard#67Mohammad-Hassan027 wants to merge 3 commits into
Mohammad-Hassan027 wants to merge 3 commits into
Conversation
- Created reusable brutalist Skeleton component - Replaced 'DOWNLOADING_NODES...' text with skeleton UI in MarketMapPage - Updated loading states to match GlassCard dimensions and prevent layout shift Resolves jpdevhub#60
…classname for font
|
@Mohammad-Hassan027 is attempting to deploy a commit to the karan3431's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🎉 Thank you for your Pull Request! We're thrilled to have your contribution to FreshScan AI. Before we review, please make sure you have:
A maintainer will review your code as soon as possible! |
Author
|
Leaderboard Loader
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created reusable brutalist Skeleton component
DOWNLOADING_NODES...text with skeleton UI in MarketMapPageResolves #60
Description
This PR addresses issue #60 by improving the perceived performance of data-fetching states across the application. I am submitting this contribution as part of SSoC26.
Changes included:
Skeleton.tsxComponent: Created a new, reusable brutalist/cyberpunk skeleton component utilizing thebg-surface-midcolor class and a smooth pulse animation.MarketMapPage.tsx: Removed the generic "DOWNLOADING_NODES..." text. Implemented the new Skeleton loader structured to mimic the exact dimensions of the GlassCard component. This ensures a seamless transition with zero layout shift when the market data finishes loading.Leaderboard.tsx: (If you completed this part) Replaced the fetching state with skeleton rows that map directly to the table column widths.Screenshots/Video
wait ..
Checklist
npm run lintpasses with no errorsnpm run buildcompiles without TypeScript errorspython -m pytestpasses.envfiles, API keys, secrets, model weights, or__pycache__in this diffmain, not merged