added bilinear filtering for drawimage#72
Open
enkimute wants to merge 4 commits intojoshmarinacci:masterfrom
Open
added bilinear filtering for drawimage#72enkimute wants to merge 4 commits intojoshmarinacci:masterfrom
enkimute wants to merge 4 commits intojoshmarinacci:masterfrom
Conversation
Fixes bug when alpha from foreground image would overwrite alpha from background image
Use composite when drawing images
joshmarinacci
approved these changes
Jan 29, 2019
Owner
joshmarinacci
left a comment
There was a problem hiding this comment.
This looks good to me. I approve.
Author
|
… On Mon, Dec 13, 2021 at 1:27 PM Charles Robertson ***@***.***> wrote:
Sorry. What is bi-linear filtering?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLHMI33VHBL5FCMTX3EGC3UQXRCVANCNFSM4GJ7XPDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
@enkimute Does this help to smooth drawImage() results of a clip. Will your fix, effectively create anti-aliasing? Thank you 🙏 |
Author
|
Hi Charles,
This fix only affects how pixels are sampled from the source image. It will
not help you create anti-aliased clipping masks.
(the easiest approach to get that would be to render your image larger, and
then downsample)
Regards,
Steven.
…On Mon, Dec 13, 2021 at 3:14 PM Charles Robertson ***@***.***> wrote:
@enkimute <https://github.com/enkimute> Does this help to smooth
*drawImage()* results of a clip.
So for instance I have clipped an image, using an *arc()*, to create a
circular avatar.
But, it is aliased.
Will your fix, effectively create anti-aliasing?
Thank you 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLHMI3JAMI6I6O2O4LFX7TUQX5V3ANCNFSM4GJ7XPDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
@enkimute Hi Steven. Thanks for your reply. My code is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist
Description