Feat/imputation improvements#79
Merged
Merged
Conversation
…reporting triggers include PSI/Cramér’s V; add clinical_all_features_e2e script; misc compatibility
…ggers, new clinical_all_features_e2e script, CLI flags)
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR overhauls imputation to be strategy-agnostic with global and per-column tuning, refreshes documentation and reporting (including categorical bias metrics), adds a comprehensive clinical E2E script, bumps version to 1.2.0, and delivers GUI bug fixes and compatibility improvements. Class diagram for imputation configuration and strategy selectionclassDiagram
class ImputationConfig {
+strategy: str
+params: dict
+per_column: dict
+tuning: bool
}
class Imputer {
+fit_transform(data)
+set_strategy(strategy)
+set_params(params)
+set_per_column(per_column)
+run_tuning()
}
ImputationConfig <|-- Imputer
Imputer o-- "1..*" ImputationStrategy
class ImputationStrategy {
+name: str
+apply(data, params)
}
ImputationStrategy <|-- MeanImputer
ImputationStrategy <|-- MedianImputer
ImputationStrategy <|-- ModeImputer
ImputationStrategy <|-- KNNImputer
ImputationStrategy <|-- MICEImputer
ImputationStrategy <|-- SVDImputer
ImputationStrategy <|-- NoneImputer
Class diagram for bias metrics reportingclassDiagram
class BiasMetrics {
+numeric_metrics: list
+categorical_metrics: list
+report_triggers(variable)
}
BiasMetrics <|-- NumericBiasMetrics
BiasMetrics <|-- CategoricalBiasMetrics
class NumericBiasMetrics {
+SMD
+VarianceRatio
+KS
}
class CategoricalBiasMetrics {
+PSI
+CramersV
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a flexible, strategy-agnostic imputation framework with global and per-column settings and mask-and-score tuning; enhance GUI, CLI scripts, and reporting diagnostics; update documentation; bump version to 1.2.0; fix GUI metric defaults and typing compatibility.
New Features:
Bug Fixes:
Enhancements:
Build:
Documentation: