Added additional error checking to FileWatch::Tail#_open_file#35
Open
nealpatel-work wants to merge 1 commit into
Open
Added additional error checking to FileWatch::Tail#_open_file#35nealpatel-work wants to merge 1 commit into
nealpatel-work wants to merge 1 commit into
Conversation
Collaborator
|
I agree that this is a poor error message, but not sure if adding the string "or stat" helps users understand that the problem comes from the directory's permissions. begin
# ...
rescue
# ..
dir = File.dirname("dir/file")
unless File.executable?(dir) && File.writable?(dir) do
@logger.error "Directory has permission issues #{File.stat(dir).inspect}"
end
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a bug I encountered.
FileWatch tried to
statfiles located in directories without the+xflag. This caused FileWatch to raise an error (Errno::EACCES), which it shouldn't do (regardless of what permissions are set on the file).