[4.x] resolve PHPUnit Notices

Tests/DatabaseAwareTraitTest.php

@@ -30,7 +30,7 @@ class DatabaseAwareTraitTest extends TestCase
      */
     public function testGetSetDatabase(): void
     {
-        $db = $this->createMock(DatabaseInterface::class);
+        $db = $this->createStub(DatabaseInterface::class);
 
         $trait = new class () {
             use DatabaseAwareTrait;

Tests/DatabaseExporterTest.php

@@ -7,14 +7,10 @@
 
 namespace Joomla\Database\Tests;
 
-use Joomla\Database\DatabaseExporter;
-use Joomla\Database\DatabaseImporter;
 use Joomla\Database\DatabaseInterface;
 use Joomla\Database\Tests\Stubs\TestDatabaseExporter;
-use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
 use Joomla\Test\TestHelper;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -111,12 +107,11 @@ public function testFrom($from, bool $shouldRaiseException)
     }
 
     /**
-     * @testdox  A database drier can be set to the exporter
+     * @testdox  A database driver can be set to the exporter
      */
     public function testSetDbo()
     {
-        /** @var DatabaseInterface|MockObject $db */
-        $db = $this->createMock(DatabaseInterface::class);
+        $db = $this->createStub(DatabaseInterface::class);
 
         $this->assertSame($this->exporter, $this->exporter->setDbo($db), 'The exporter supports method chaining');
     }

Tests/DatabaseFactoryTest.php

@@ -131,7 +131,7 @@ public function testGetExporter(string $adapter, bool $shouldRaiseException, boo
         $databaseDriver = null;
 
         if ($createDb) {
-            $databaseDriver = $this->createMock(MysqliDriver::class);
+            $databaseDriver = $this->createStub(MysqliDriver::class);
         }
 
         $exporter = $this->factory->getExporter($adapter, $databaseDriver);
@@ -194,7 +194,7 @@ public function testGetImporter(string $adapter, bool $shouldRaiseException, boo
         $databaseDriver = null;
 
         if ($createDb) {
-            $databaseDriver = $this->createMock(MysqliDriver::class);
+            $databaseDriver = $this->createStub(MysqliDriver::class);
         }
 
         $importer = $this->factory->getImporter($adapter, $databaseDriver);
@@ -239,7 +239,7 @@ public function testGetIterator(string $adapter, bool $createStatement)
         $statement = null;
 
         if ($createStatement) {
-            $statement = $this->createMock(StatementInterface::class);
+            $statement = $this->createStub(StatementInterface::class);
         }
 
         $this->assertInstanceOf(
@@ -287,7 +287,7 @@ public function testGetQuery(string $adapter, bool $shouldRaiseException, bool $
         $databaseDriver = null;
 
         if ($createDb) {
-            $databaseDriver = $this->createMock(MysqliDriver::class);
+            $databaseDriver = $this->createStub(MysqliDriver::class);
         }
 
         $this->assertInstanceOf(

Tests/DatabaseImporterTest.php

@@ -7,12 +7,9 @@
 
 namespace Joomla\Database\Tests;
 
-use Joomla\Database\DatabaseImporter;
 use Joomla\Database\DatabaseInterface;
 use Joomla\Database\Tests\Stubs\TestDatabaseImporter;
-use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
 use Joomla\Test\TestHelper;
-use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -65,12 +62,11 @@ public function testAsXml()
     }
 
     /**
-     * @testdox  A database drier can be set to the importer
+     * @testdox  A database driver can be set to the importer
      */
     public function testSetDbo()
     {
-        /** @var DatabaseInterface|MockObject $db */
-        $db = $this->createMock(DatabaseInterface::class);
+        $db = $this->createStub(DatabaseInterface::class);
 
         $this->assertSame($this->importer, $this->importer->setDbo($db), 'The importer supports method chaining');
     }

Tests/DatabaseIteratorTest.php

@@ -10,6 +10,7 @@
 use Joomla\Database\FetchMode;
 use Joomla\Database\StatementInterface;
 use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Stub;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -27,7 +28,7 @@ public function testInstantiation()
 
         $i = 0;
 
-        $statement->expects($this->any())
+        $statement->expects($this->once())
                   ->method('fetch')
                   ->willReturnCallback(
                       function () use ($i) {
@@ -229,8 +230,8 @@ public function testConstructorExceptionForNonExistingClass()
     {
         $this->expectException(\InvalidArgumentException::class);
 
-        /** @var StatementInterface|MockObject $statement */
-        $statement = $this->createMock(StatementInterface::class);
+        /** @var StatementInterface|Stub $statement */
+        $statement = $this->createStub(StatementInterface::class);
 
         $iterator = new DatabaseIterator($statement, null, \NonExistingClass::class);
     }

Tests/DatabaseQueryTest.php

@@ -13,7 +13,7 @@
 use Joomla\Database\ParameterType;
 use Joomla\Database\Tests\Stubs\TestDatabaseQuery;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Stub;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -24,14 +24,14 @@ class DatabaseQueryTest extends TestCase
     /**
      * Object being tested
      *
-     * @var  MockObject|DatabaseQuery
+     * @var  DatabaseQuery
      */
     private $query;
 
     /**
      * Mock database driver
      *
-     * @var  MockObject|DatabaseInterface
+     * @var  Stub|DatabaseInterface
      */
     private $db;
 
@@ -46,7 +46,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->db    = $this->createMock(DatabaseInterface::class);
+        $this->db    = $this->createStub(DatabaseInterface::class);
         $this->query = new TestDatabaseQuery($this->db);
     }
 
@@ -168,8 +168,7 @@ public static function dataConcatenate(): array
     #[DataProvider('dataConcatenate')]
     public function testConcatenate(array $values, ?string $separator, string $expected)
     {
-        $this->db->expects($this->any())
-            ->method('quote')
+        $this->db->method('quote')
             ->willReturnCallback(function ($text, $escape = true) {
                 return "'" . $text . "'";
             });
@@ -538,19 +537,22 @@ public static function dataNullDate(): array
     #[DataProvider('dataNullDate')]
     public function testNullDate(bool $quoted, string $expected)
     {
-        $this->db->expects($this->once())
+        $db    = $this->createMock(DatabaseInterface::class);
+        $query = new TestDatabaseQuery($db);
+
+        $db->expects($this->once())
             ->method('getNullDate')
             ->willReturn('0000-00-00 00:00:00');
 
-        $this->db->expects($this->any())
+        $db->expects($this->exactly((int) $quoted))
             ->method('quote')
             ->willReturnCallback(function ($text, $escape = true) {
                 return "'" . $text . "'";
             });
 
         $this->assertSame(
             $expected,
-            $this->query->nullDate($quoted)
+            $query->nullDate($quoted)
         );
     }
 
@@ -582,7 +584,9 @@ public function testIsNullDatetimeNoDates()
      */
     public function testIsNullDatetimeWithDates()
     {
-        $this->db->expects($this->any())
+        $db = $this->createMock(DatabaseInterface::class);
+
+        $db->expects($this->once())
             ->method('quote')
             ->willReturnCallback(function ($text, $escape = true) {
                 foreach ($text as $k => $v) {
@@ -592,7 +596,7 @@ public function testIsNullDatetimeWithDates()
                 return $text;
             });
 
-        $query = new class ($this->db) extends DatabaseQuery {
+        $query = new class ($db) extends DatabaseQuery {
             protected $nullDatetimeList = ['0000-00-00 00:00:00', '1000-01-01 00:00:00'];
 
             public function groupConcat($expression, $separator = ',')
@@ -643,15 +647,18 @@ public function testOrder()
      */
     public function testQuote()
     {
-        $this->db->expects($this->any())
+        $db    = $this->createMock(DatabaseInterface::class);
+        $query = new TestDatabaseQuery($db);
+
+        $db->expects($this->once())
             ->method('quote')
             ->willReturnCallback(function ($text, $escape = true) {
                 return "'" . $text . "'";
             });
 
         $this->assertSame(
             "'foo'",
-            $this->query->quote('foo')
+            $query->quote('foo')
         );
     }
 
@@ -672,15 +679,18 @@ public function testQuoteException()
      */
     public function testQuoteName()
     {
-        $this->db->expects($this->any())
+        $db    = $this->createMock(DatabaseInterface::class);
+        $query = new TestDatabaseQuery($db);
+
+        $db->expects($this->once())
             ->method('quoteName')
             ->willReturnCallback(function ($text, $escape = true) {
                 return "`" . $text . "`";
             });
 
         $this->assertSame(
             "`foo`",
-            $this->query->quoteName('foo')
+            $query->quoteName('foo')
         );
     }
 
@@ -1255,13 +1265,15 @@ public function processLimit($query, $limit, $offset = 0)
      */
     public function testCastingToStringInsertSet()
     {
-        $this->db->expects($this->any())
+        $db = $this->createMock(DatabaseInterface::class);
+
+        $db->expects($this->once())
             ->method('quote')
             ->willReturnCallback(function ($text, $escape = true) {
                 return "'" . $text . "'";
             });
 
-        $query = new class ($this->db) extends DatabaseQuery {
+        $query = new class ($db) extends DatabaseQuery {
             public function groupConcat($expression, $separator = ',')
             {
                 return '';
@@ -1289,13 +1301,15 @@ public function processLimit($query, $limit, $offset = 0)
      */
     public function testCastingToStringInsertColumnsValues()
     {
-        $this->db->expects($this->any())
+        $db = $this->createMock(DatabaseInterface::class);
+
+        $db->expects($this->once())
             ->method('quote')
             ->willReturnCallback(function ($text, $escape = true) {
                 return "'" . $text . "'";
             });
 
-        $query = new class ($this->db) extends DatabaseQuery {
+        $query = new class ($db) extends DatabaseQuery {
             public function groupConcat($expression, $separator = ',')
             {
                 return '';