rework mmusics logic#4
Open
jonolt wants to merge 15 commits into
Open
Conversation
- logging and reporting does not work - TestConversionFileFile.test_catch_ffmpeg_error[file-->file] fails
- added MultiLineFormatter
- increased PyYAML min version to 5.10 because of some incompatibility with python 3.10
- moved is_audio, is_supported_audio, UnsupportedAudio to _misc - created superclass for Metadata and MetadataGroup - now only Metadata uses the Metaclass - minor improvement to file sync - fixed change counter bug by changing error -1 to bit
- fixed delete nonexistent folder - ignore hidden path linux only atm - moved is_audio from formats to ffmpeg - using ffmpeg -formats output to determine audio extensions - implemented ignoring of hidden path in tree creation - AlbumMetadata now stores non audio file paths - added is_hidden_path function (not tested)
added documentation minor bugfixes
- removed redundant x_common_path variable - fixed delete-files on empty dir
- removed wrong PERFORMER argument from config - enforcing target file/folder suffix/no suffix in help - reimplemented source/target type detection - fixed files on file-level not deleted - added error handling to MP3File.file_save lists - added test helper for custom debugging
The code does not work with SQLAlchemy 2
- minor bugfixes - added test of summary stat
- mitigated mp3 bug by catching exception and printing warning - added files to test to reproduce error - modified _run_custom to run with cmd from a working folder AttributeError: 'NoneType' object has no attribute 'list_metadata'
- sqlalchemy throws errors py14-min, will be removed in next commit - replaced deprecated distutils with shutils - replaced distutils.util.strtobool with onw implementation - added exceptions when modules are not loaded/initialized - added special handling for id3 lyrics tag mutagen.id3.USLT - removed old python versions, increased some dependencies - modified tox to use pyenv interpreters
- bumped version to 0.5.0b2 - fixed bug where dry-run would create folders and files - stats are now as close to the not dry-run case as possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs:
Nice to have or fix in release commit.