[Minor] Update SparkSessionBuilder.create to use existing SparkContext if it already exists#1
Open
jonmio wants to merge 7 commits into
Open
[Minor] Update SparkSessionBuilder.create to use existing SparkContext if it already exists#1jonmio wants to merge 7 commits into
jonmio wants to merge 7 commits into
Conversation
jonmio
changed the title
Add test to ensure SparkConf is not called when a session exists.
Add test to verify mutable SQL configs are applied per session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As titled this is a minor hygiene improvement which brings the create and getOrCreate codepaths closer together. Prior to this PR, the create codepath would always create a new SparkConf and pass that to SparkContext.getOrCreate. This is not necessary and diverges from the getOrCreate codepath when a session/SparkContext already exists.
Why are the changes needed?
Code hygene
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests are sufficient here
Was this patch authored or co-authored using generative AI tooling?
No