Add an accumulator type to the Absorb trait#138
Closed
rs-sac wants to merge 1 commit intojonhoo:mainfrom
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
When applying several operations to the same value, certain operations may be faster to compute once at the end rather than incrementally after each change. E.g. if values are `Vec<u64>`, it would be faster to compute an average or to sort once, after all updates are applied, rather than incrementally after each update. Add an associated type to the trait for the accumulator, pass it to the absorb methods, and call a new finalize method at the end of each absorb loop. If not needed, the accumulator can be set to `()` and the finalize method can be left with its default no-op implementation.
Owner
|
@rs-sac After we discussed this offline, do you still think you need this? For anyone reading this, the quick summary was to change the |
Author
|
We don't need this for now. The jury may still be a little out, but I implemented batching and merging outside of left-right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying several operations to the same value, certain operations may be faster to compute once at the end rather than incrementally after each change. E.g. if values are
Vec<u64>, it would be faster to compute an average or to sort once, after all updates are applied, rather than incrementally after each update.Add an associated type to the trait for the accumulator, pass it to the absorb methods, and call a new finalize method at the end of each absorb loop. If not needed, the accumulator can be set to
()and the finalize method can be left with its default no-op implementation.This change is