chore(websocket): add JmWebsocketContext#1244
Merged
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
theborakompanioni
added
enhancement
parrth20
requested changes
May 10, 2026
Member
kishore08-07
left a comment
kishore08-07
left a comment
There was a problem hiding this comment.
nit: enableAuthentiction is misspelled; could you rename it to enableAuthentication?
Everything else looks fine to me.
parrth20
approved these changes
May 11, 2026
Member
parrth20
left a comment
parrth20
left a comment
There was a problem hiding this comment.
Otherwise LGTM we are GTG !!!
kishore08-07
approved these changes
May 11, 2026
theborakompanioni
force-pushed
the
tbk/websocket-context
branch
from
40e9b35 to
83d957d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a context for websocket stuff.
Websocket connection has been shared, but we really only need one connection (yet).
No custom message handling by children, since we also do not need that at the moment.