chore(ui): improve footer on small screens#1243
Open
theborakompanioni wants to merge 3 commits into
Open
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
theborakompanioni
added
the
UI/UX
parrth20
reviewed
May 10, 2026
Comment on lines
+87
to
+88
| <div className="order-last flex inline-block flex-1 text-xs sm:order-first"> | ||
| <Trans i18nKey="footer.warning"> |
Member
There was a problem hiding this comment.
Small UX nit: footer.warning includes a <br/> in the translation string, and this gets rendered through this <Trans>. Since the wrapper is now flex, that line break may not behave like normal text flow. Could we make this wrapper a normal block/text container instead of flex inline-block?
parrth20
requested changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test
run storybook:uphttp://localhost:6006/?path=/story/layout-appfooter--default&globals=backgrounds.grid:!false;viewport.value:525-568