feat(wallet): add data-journey-state to MainWalletPage with tests#1226
Open
rxiddhi wants to merge 3 commits into
Open
feat(wallet): add data-journey-state to MainWalletPage with tests#1226rxiddhi wants to merge 3 commits into
rxiddhi wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a derived
data-journey-stateattribute to the main wallet container inMainWalletPage.It also:
service-offlinewins overno-walletThis is an additive UI-only change intended to make follow-up state-aware guidance work easier to implement and test. It does not change backend behavior or existing wallet flows.
Motivation / Context
Jam already has the wallet and service state needed to identify common first-run situations, but that state is not currently surfaced in one predictable place on the main wallet route.
Exposing a deterministic journey-state marker is a small, low-risk step toward better onboarding and contextual wallet guidance.
Dependencies
Risk
Low. This change only adds a DOM attribute and pure derivation logic, with unit and RTL coverage.
Visual Demo (For contributors especially)
Image Demo
The screenshot below shows the main wallet page with Chrome DevTools open and the main wallet container selected in the Elements panel.
The selected node renders:
data-journey-state="empty-wallet"This demonstrates that the derived journey state is present in the DOM and available for follow-up guidance work, even though this PR does not introduce a visible UI change yet.