Skip to content

feat: add data-journey-state with tests, docs, and friction audit#1206

Closed
23bsm038-Mahi wants to merge 3 commits into
joinmarket-webui:v2from
23bsm038-Mahi:feat/journey-attribute
Closed

feat: add data-journey-state with tests, docs, and friction audit#1206
23bsm038-Mahi wants to merge 3 commits into
joinmarket-webui:v2from
23bsm038-Mahi:feat/journey-attribute

Conversation

@23bsm038-Mahi
Copy link
Copy Markdown
Contributor

@23bsm038-Mahi 23bsm038-Mahi commented Apr 14, 2026

What:
Added a data-journey-state attribute to the main wallet container.

How:
Used a small helper to derive the state based on wallet balance and fee configuration (loading, empty, needs_fee, ready). Also handled a few edge cases like invalid or negative balance and added unit + component tests.

Why:
The goal is to make the UI a bit more aware of the wallet state so it can guide users better.

Also:
Added a short wallet state friction audit and updated the developer docs with how to simulate different journey states during testing.

Note:
Some unrelated tests fail locally due to locale formatting and Playwright setup, but tests related to this change pass.

@23bsm038-Mahi
Copy link
Copy Markdown
Contributor Author

23bsm038-Mahi commented Apr 14, 2026

Hi @theborakompanioni, I added a data-journey-state attribute to the main wallet container based on wallet balance and fee config.Used a small helper to decide the state (loading, empty, needs_fee, ready) and handled basic edge cases. Also added some unit and component tests to check it works as expected. Idea is to make the UI more aware of the wallet state so we can guide users better later.
Let me know if this should be placed somewhere else or if anything should be changed.

@23bsm038-Mahi 23bsm038-Mahi changed the title feat(wallet): add data-journey-state attribute to MainWalletPage feat: add data-journey-state with derived wallet logic and tests Apr 18, 2026
@23bsm038-Mahi
Copy link
Copy Markdown
Contributor Author

Hi, I’ve also added the wallet state friction audit and updated the developer docs with a section on simulating journey states.
Please let me know if anything should be improved or adjusted.

@23bsm038-Mahi 23bsm038-Mahi changed the title feat: add data-journey-state with derived wallet logic and tests feat: add data-journey-state with tests, docs, and friction audit Apr 18, 2026
@parrth20 parrth20 closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants