feat: add data-journey-state with tests, docs, and friction audit#1206
Closed
23bsm038-Mahi wants to merge 3 commits into
Closed
feat: add data-journey-state with tests, docs, and friction audit#120623bsm038-Mahi wants to merge 3 commits into
23bsm038-Mahi wants to merge 3 commits into
Conversation
Contributor
Author
|
Hi @theborakompanioni, I added a data-journey-state attribute to the main wallet container based on wallet balance and fee config.Used a small helper to decide the state (loading, empty, needs_fee, ready) and handled basic edge cases. Also added some unit and component tests to check it works as expected. Idea is to make the UI more aware of the wallet state so we can guide users better later. |
Contributor
Author
|
Hi, I’ve also added the wallet state friction audit and updated the developer docs with a section on simulating journey states. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Added a data-journey-state attribute to the main wallet container.
How:
Used a small helper to derive the state based on wallet balance and fee configuration (loading, empty, needs_fee, ready). Also handled a few edge cases like invalid or negative balance and added unit + component tests.
Why:
The goal is to make the UI a bit more aware of the wallet state so it can guide users better.
Also:
Added a short wallet state friction audit and updated the developer docs with how to simulate different journey states during testing.
Note:
Some unrelated tests fail locally due to locale formatting and Playwright setup, but tests related to this change pass.