refactor(send): replace imperative lifecycle tracking with declarative state#1160
Draft
parrth20 wants to merge 1 commit into
Draft
refactor(send): replace imperative lifecycle tracking with declarative state#1160parrth20 wants to merge 1 commit into
parrth20 wants to merge 1 commit into
Conversation
…e state - Remove collaborativeLifecycleRef, currentUtxoSnapshotRef, refetchWalletInfoRef - Remove verifyCollaborativeCompletion while-loop with hardcoded delay - Remove setInterval-based wallet info refresh during collaborative flow - Detect coinjoin completion declaratively via previousCoinjoinRunningRef tracking the running->stopped transition from jmSession state - Simplify onPaymentConfirmed and onAbortCoinjoin handlers
parrth20
added
refactoring
Collaborator
|
Hey @parrth20, is it okay for you to have this on hold for a little bit longer? Next I want to tackle detecting when a utxo has been spent and fixing the cancellation of taker operations. |
Member
Author
okay I'll keep this branch aside, do lmk when i can continue !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1136. removes the imperative collaborativeLifecycleRef, verifyCollaborativeCompletion while-loop, and setInterval wallet refresh,
coinjoin completion is now detected declaratively by tracking jmSession.coinjoin_in_process transitions.
changes overview which i have made
removed collaborativeLifecycleRef, currentUtxoSnapshotRef, refetchWalletInfoRef
removed while-loop with hardcoded delay
detected completion via previousCoinjoinRunningRef (running → stopped)
ping @theborakompanioni