Skip to content

add click ID fields to Utm type for ad platform tracking#3

Open
arifraveendran wants to merge 1 commit intomasterfrom
feat/click-id-persistence
Open

add click ID fields to Utm type for ad platform tracking#3
arifraveendran wants to merge 1 commit intomasterfrom
feat/click-id-persistence

Conversation

@arifraveendran
Copy link
Copy Markdown
Contributor

Summary

  • Adds 9 ad platform click ID fields (gclid, fbclid, msclkid, gbraid, wbraid, dclid, ttclid, li_fat_id, ScCid) to the Utm type
  • Adds index signature [key: string]: string for future-proofing
  • No logic changes — formUrl() already iterates all keys in the utm object

Related PRs

  • joinditto/dma — passes click IDs via loadTimely()
  • joinditto/timely-frontend#95 — receives click IDs in utmKeys

Test plan

  • Build the plugin successfully
  • Verify DMA can pass click IDs to the Timely iframe without TypeScript errors

- Add gclid, fbclid, msclkid and 6 other click ID params to Utm type
- Add index signature for future-proofing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant