Clear the ruff backlog and re-block the lint in CI (closes #7)

.github/workflows/ci.yml

@@ -30,11 +30,6 @@ jobs:
           pip install -e '.[dev,full]'
 
       - name: Lint with ruff
-        # Advisory for now: the ruff step had never actually run (the workflow
-        # only triggered on `main` while the repo lives on `master`), so it
-        # surfaces a large backlog of pre-existing style findings. Tracked for a
-        # dedicated cleanup; kept non-blocking so it doesn't gate unrelated work.
-        continue-on-error: true
         run: ruff check src/
 
       - name: Dangling-code audit (stubs + swallowed excepts)

src/pacer_cli/auth.py

@@ -9,7 +9,6 @@
 """
 
 from dataclasses import dataclass
-from typing import Optional
 
 import requests
 
@@ -21,8 +20,8 @@ class AuthResult:
     """Result of PACER authentication attempt."""
 
     success: bool
-    token: Optional[str] = None  # nextGenCSO 128-byte token
-    error: Optional[str] = None
+    token: str | None = None  # nextGenCSO 128-byte token
+    error: str | None = None
     login_result: str = ""
 
 
@@ -41,7 +40,7 @@ def generate_totp(secret: str) -> str:
 
 def authenticate(
     config: PacerConfig,
-    otp_code: Optional[str] = None,
+    otp_code: str | None = None,
 ) -> AuthResult:
     """Authenticate with PACER and get session token.
 
@@ -152,7 +151,7 @@ def logout(config: PacerConfig, token: str) -> bool:
         return False
 
 
-def test_credentials(config: PacerConfig, otp_code: Optional[str] = None) -> AuthResult:
+def test_credentials(config: PacerConfig, otp_code: str | None = None) -> AuthResult:
     """Test PACER credentials without keeping the session.
 
     Authenticates and immediately logs out to verify credentials work.