Skip to content

Docx mw feedback#264

Open
eanokian wants to merge 5 commits intodevfrom
docx_mw_feedback
Open

Docx mw feedback#264
eanokian wants to merge 5 commits intodevfrom
docx_mw_feedback

Conversation

@eanokian
Copy link
Copy Markdown
Collaborator

@eanokian eanokian commented Apr 13, 2026

Pull Request

this PR contains updates coming from Medical Writing feedback

Checks

  • (Have you updated the changelog.md ?)

@eanokian eanokian requested a review from munoztd0 April 13, 2026 21:10
@eanokian eanokian self-assigned this Apr 13, 2026
@munoztd0 munoztd0 mentioned this pull request Apr 14, 2026
32 tasks
@eanokian
Copy link
Copy Markdown
Collaborator Author

pending to know if the empty footnote row should be included in the docx exporter if the TLG does not have a footnote. If this applies, then:

  1. update NEWS.md
  2. add unit test that tests that
  3. update snapshots

@munoztd0 munoztd0 marked this pull request as ready for review April 14, 2026 09:18
@munoztd0 munoztd0 marked this pull request as draft April 14, 2026 09:18
@eanokian eanokian marked this pull request as ready for review April 16, 2026 08:59
@eanokian
Copy link
Copy Markdown
Collaborator Author

we can merge into 'dev' the changes we have so far.
the blank row if the TLG doesn't have footnotes is something that we will skip for now as it may not be needed. I removed the code in this PR that implemented that behaviour.

munoztd0

This comment was marked as outdated.

@munoztd0
Copy link
Copy Markdown
Collaborator

still an issue in ubuntu ?

Joining with `by = join_by(USUBJID)`
mmrm() registered as emmeans extension
Saving _problems/test-docx_exporter_functions-651.R
[ FAIL 1 | WARN 0 | SKIP 0 | PASS 817 ]

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-docx_exporter_functions.R:651:3'): export_TLG_as_docx() works with basic example ──
Expected `node_str` to equal "<w:tbl w:table_index=\"1\">".
Differences:
`actual`:   "<w:tbl>"                    
`expected`: "<w:tbl w:table_index=\"1\">"


[ FAIL 1 | WARN 0 | SKIP 0 | PASS 817 ]
Error:
! Test failures.

@munoztd0 munoztd0 self-requested a review April 16, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants