Add bulk import feature for players#109
Open
torfinnnome wants to merge 2 commits intojohnridesabike:masterfrom
Open
Add bulk import feature for players#109torfinnnome wants to merge 2 commits intojohnridesabike:masterfrom
torfinnnome wants to merge 2 commits intojohnridesabike:masterfrom
Conversation
👷 Deploy request for coronate accepted.
|
Owner
|
Thanks for the contribution. I haven't had a chance to review it in detail, but this seems like a useful addition. Normally I'd ask that we add a test for the CSV parser, but the test suite is unfortunately broken right now so that may have to wait until we fix/replace that too. Once I have a chance for a closer review, I we can merge this if there aren't any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85.
Thanks for making Coronate! I was missing this feature, when organising an event at our local school.