Skip to content

Hide feed icon when 'Read Later' feed is selected #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jocmp merged 2 commits into from
Apr 8, 2026
Merged

Hide feed icon when 'Read Later' feed is selected #2003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfb4ea4
Hide feed icon when 'Read Later' is selected
jocmp Apr 8, 2026
3de1272
Fix Read Later sidebar and icon
jocmp Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/com/capyreader/app/ui/articles/ArticleList.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,12 @@ fun ArticleList(
refreshingAll: Boolean,
enableMarkReadOnScroll: Boolean = false,
dimReadArticles: Boolean = true,
showIcons: Boolean = true,
) {
val articleOptions = rememberArticleOptions().copy(
val options = rememberArticleOptions()
val articleOptions = options.copy(
dim = dimReadArticles,
showIcon = options.showIcon && showIcons,
)
val currentTime = rememberCurrentTime()
val localDensity = LocalDensity.current
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/com/capyreader/app/ui/articles/ArticleScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ import com.capyreader.app.ui.articles.media.ArticleMediaView
import com.capyreader.app.ui.collectChangesWithCurrent
import com.capyreader.app.ui.collectChangesWithDefault
import com.capyreader.app.ui.components.ArticleSearch
import com.capyreader.app.ui.components.LocalSnackbarHost
import com.capyreader.app.ui.components.SearchState
import com.capyreader.app.ui.provideLinkOpener
import com.capyreader.app.ui.rememberLazyListState
import com.capyreader.app.ui.rememberLocalConnectivity
import com.capyreader.app.ui.components.LocalSnackbarHost
import com.jocmp.capy.Article
import com.jocmp.capy.ArticleFilter
import com.jocmp.capy.Feed
Expand Down Expand Up @@ -603,6 +603,7 @@ fun ArticleScreen(
enableMarkReadOnScroll = enableMarkReadOnScroll,
refreshingAll = viewModel.refreshingAll,
dimReadArticles = filter !is ArticleFilter.Starred,
showIcons = !filter.isReadLaterFeed(readLaterFeed),
onMarkAllRead = { range ->
onMarkAllRead(range)
},
Expand Down
4 changes: 1 addition & 3 deletions app/src/main/java/com/capyreader/app/ui/articles/ArticleScreenViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,9 @@ class ArticleScreenViewModel(
val readLaterFeed: Flow<Feed?> = combine(
account.feeds,
_counts,
filter,
) { feeds, latestCounts, filter ->
) { feeds, latestCounts ->
feeds.find { it.isReadLater }
?.let { copyFeedCounts(it, latestCounts) }
?.takeIf { it.count > 0 || filter.status != ArticleStatus.UNREAD }
}

private val nextFilterListener: Flow<NextFilter?> =
Expand Down
4 changes: 4 additions & 0 deletions capy/src/main/java/com/jocmp/capy/ArticleFilter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ sealed class ArticleFilter(open val status: ArticleStatus) {
return this is Starred
}

fun isReadLaterFeed(feed: Feed?): Boolean {
return feed != null && isFeedSelected(feed)
}

fun withStatus(status: ArticleStatus): ArticleFilter {
return when (this) {
is Articles -> copy(articleStatus = status)
Expand Down
Loading