Skip to content

Check if cpu.max file is non-empty before reading#479

Merged
tomMoral merged 11 commits intojoblib:masterfrom
mindflayer:patch-1
Mar 4, 2026
Merged

Check if cpu.max file is non-empty before reading#479
tomMoral merged 11 commits intojoblib:masterfrom
mindflayer:patch-1

Conversation

@mindflayer
Copy link
Copy Markdown
Contributor

@mindflayer mindflayer commented Jan 28, 2026

Fix for #478

tomMoral
tomMoral approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomMoral
Copy link
Copy Markdown
Contributor

tomMoral commented Jan 28, 2026

It seems that this make some test fails: test_cpu_count_cgroup_limit.

@mindflayer
Copy link
Copy Markdown
Contributor Author

mindflayer commented Jan 28, 2026 •
edited
Loading

It was a bit more complex than I firstly thought, and of course I had to try everything from an environment where Docker was setting everything up properly.
I added a way to skip the test when the environment is not configured correctly, not sure if that's what we want.
Then I added two more tests with edge cases. Let me know what you think!

tomMoral
tomMoral reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for investigating this.
It is indeed more complex than it looked 😅

This is just a few remarks from a quick look. The last test seems to not call the expected func?

The changes seem reasonable but I need more time to read them in detail, will try tomorrow.

Comment thread tests/test_loky_module.py Outdated
Comment thread tests/test_loky_module.py Outdated
Comment thread loky/backend/context.py Outdated
mindflayer and others added 4 commits January 28, 2026 19:52
@mindflayer
Black'ed.
ab7a0c3
@mindflayer
Useless.
5e3c277
@mindflayer
Fix tests.
c336f97
@mindflayer @tomMoral
Apply suggestion from @tomMoral
8ad405d 
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
@mindflayer
Copy link
Copy Markdown
Contributor Author

mindflayer commented Jan 28, 2026 •
edited
Loading

The changes seem reasonable but I need more time to read them in detail, will try tomorrow.

Take your time, I had this error happening for ages. Today the hidden boyscout in me thought it was the time to stop rebooting the system just to test this project of mine. :)

@mindflayer
Copy link
Copy Markdown
Contributor Author

mindflayer commented Feb 14, 2026

@tomMoral anything more I could do for helping out here?

tomMoral
tomMoral approved these changes Feb 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, the change is reasonable and well tested.

Just a few more simplification for the code

Comment thread tests/test_loky_module.py Outdated
Comment thread loky/backend/context.py Outdated
@mindflayer mindflayer requested a review from tomMoral February 14, 2026 09:01
@mindflayer
Copy link
Copy Markdown
Contributor Author

mindflayer commented Feb 14, 2026

I might be wrong, but the failure does not look like something related to this PR.

@mindflayer
Copy link
Copy Markdown
Contributor Author

mindflayer commented Mar 4, 2026

@tomMoral anything else I could do for helping here?

tomMoral
tomMoral approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the ping.

@tomMoral tomMoral merged commit 5098fdf into joblib:master Mar 4, 2026
10 of 13 checks passed
@mindflayer mindflayer deleted the patch-1 branch April 2, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomMoral tomMoral tomMoral approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mindflayer @tomMoral