Fix compatibility with Thunderbird 143–147#772
Open
qbit-0 wants to merge 3 commits intojobisoft:masterfrom
Open
Fix compatibility with Thunderbird 143–147#772qbit-0 wants to merge 3 commits intojobisoft:masterfrom
qbit-0 wants to merge 3 commits intojobisoft:masterfrom
Conversation
- Update strict_max_version to 146.*
- Fix hidden attribute handling: use removeAttribute("hidden") instead of
setAttribute("hidden", false) which doesn't properly unhide elements in TB143+
- Add --menuitem-icon CSS property for TB143+ menu icon compatibility
|
This fix worked on my deployment gist! Tested on Linux with 145.0 |
|
How do I install this? |
|
@jim-davenport Looks like someone made a fork and merged a similar fix. You could install their XPI: https://github.com/NielBuys/TbSync/releases/tag/v4.16.1 |
|
Works for me on Thunderbird 147, thank you! |
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiddenattribute handling for Thunderbird 143+: useremoveAttribute("hidden")instead ofsetAttribute("hidden", false), which sets the attribute to the string"false"and doesn't actually unhide the element--menuitem-iconCSS custom property for TB143+ menu icon rendering (TB switched fromlist-style-image)strict_max_versionto147.*and version to4.16.1Files changed
manifest.json— version4.16→4.16.1,strict_max_version140.*→147.*content/manager/accounts.js— fixhiddenattribute handling (3 lines)content/skin/ab.css— add--menuitem-iconproperty (2 lines)Test plan
Servers tested