Fix out-of-bounds read unpacking sparse accessor values with byteStride#296
Open
SAY-5 wants to merge 1 commit into
Open
Fix out-of-bounds read unpacking sparse accessor values with byteStride#296SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgltf_accessor_unpack_floatsadvances through the sparse values buffer view usingaccessor->stride, but the sparse values are tightly packed, socgltf_validateonly sizes that buffer view aselement_size * sparse->count. When the accessor's byteStride is larger than the packed element size, the second pass reads past the end of the values buffer view even though the file passes validation. This walks the sparse values by the packed element size instead, matching what validate checks. Fixes #295.