Implement support for KHR_node_visibility#294
Open
pablode wants to merge 1 commit into
Open
Conversation
pablode
commented
May 23, 2026
Comment on lines
+714
to
+715
| cgltf_bool has_visibility; | ||
| cgltf_node_visibility visibility; |
Author
There was a problem hiding this comment.
I've followed the extension pattern but cgltf_bool visible; could be simpler.
| cgltf_write_line(context, "}"); | ||
| } | ||
|
|
||
| if (node->has_visibility && !node->visibility.visible) |
Author
There was a problem hiding this comment.
This is an optimization like for node->mesh_gpu_instancing.attributes_count below. Otherwise, if visible matches the default value true, we would just author an empty extension struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension has now been ratified: https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Khronos/KHR_node_visibility/README.md