Fix integer overflow in accessor validation#293
Open
zeux wants to merge 1 commit into
Open
Conversation
For dense and sparse accessors, we now avoid integer overflow by making sure offset+size*count fits into size_t and if it doesn't, clamping to SIZE_MAX. SIZE_MAX should fail the validation check (even if it doesn't, it's impossible to allocate an array with size SIZE_MAX so the code becomes transitively memory safe). Also fix count=0 restrictions that could lead to benign underflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For dense and sparse accessors, we now avoid integer overflow by making sure offset+size*count fits into size_t and if it doesn't, clamping to SIZE_MAX. SIZE_MAX should fail the validation check (even if it doesn't, it's impossible to allocate an array with size SIZE_MAX so the code becomes transitively memory safe).
Also fix count=0 restrictions that could lead to benign underflow.
Fixes #287