Change cgltf_component_read_float so it handles correctly snorm#286
Open
tuket wants to merge 2 commits into
Open
Change cgltf_component_read_float so it handles correctly snorm#286tuket wants to merge 2 commits into
tuket wants to merge 2 commits into
Conversation
Author
|
Btw, in |
Owner
|
@tuket The build fails unfortunately. |
Author
|
Sorry... fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made a small change to the way
cgltf_component_read_floatconverts snorm to float.The problem was that the lowest value was not being converted to -1.0f.
For example i8 has range [-128, +127].
If you just divide by 127, the mapped range is [-1.007874f, -1.0f].
The solution is simply, if == -128, then return -1.
In addition to that, I have replaced the division for the equivalent multiplication for performance.
Here are a couple of links about snorm conversion:
OpenGL: https://github.com/nlguillemot/SNormTest
DX: https://learn.microsoft.com/en-us/windows/win32/direct3d10/d3d10-graphics-programming-guide-resources-data-conversion
Vulkan: https://docs.vulkan.org/spec/latest/chapters/fundamentals.html#fundamentals-fixedfpconv
I hope it's all good.
Thanks for making this library, it's awesome!