Conversation
PR summary bb960f36cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
These is for CI only. revert this when making PR.
mbkybky
reviewed
Aug 29, 2024
| instance {p : ℕ} [CharP k p] : CharP (AlgebraicClosure k) p := | ||
| charP_of_injective_algebraMap (RingHom.injective (algebraMap k (AlgebraicClosure k))) p | ||
|
|
||
| /-09GY Lemma: Two polynomials in $k[x]$ are relatively prime |
Collaborator
There was a problem hiding this comment.
- Write
/--instead of/-, as this will generate comments on the Mathlib documentation website. - There's no need to write “09GY Lemma:”; just mark the Stacks tag on the last line.
| /-09GY Lemma: Two polynomials in $k[x]$ are relatively prime | ||
| precisely when they have no common roots in an algebraic closure $\overline{k}$ of $k$. | ||
| [Stacks: Lemma 09GY](https://stacks.math.columbia.edu/tag/09GY) -/ | ||
| lemma IsComrime_iff_no_common_root {k : Type*} [Field k] {p q : Polynomial k} : |
Collaborator
There was a problem hiding this comment.
The name should change to isComrime_iff_no_common_root. You can read naming conventions to know how to name theorems correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added lemma that 'Two polynomials in$k[x]$ are relatively prime precisely when they$\overline{k}$ of $k$ .' into Mathlib.FieldTheory.IsAlgClosed.AlgebraicClosure.lean .
have no common roots in an algebraic closure
It could only be an application of algebraic closure, and may be placed elsewhere.
Co-authored-by: Yi Song sif4delta0@mail.ustc.edu.cn