Collection#set: with array of ids, took only first#47
Open
fvgoto wants to merge 2 commits intojj-studio:masterfrom
Open
Collection#set: with array of ids, took only first#47fvgoto wants to merge 2 commits intojj-studio:masterfrom
fvgoto wants to merge 2 commits intojj-studio:masterfrom
Conversation
bug in Backbone.Collection.prototype.set: In relational context: Breaks at first id that will go to IdQueue, instead of proceeding with remaining ids. (Correct me if I'm wrong...)
same fix as d392bb5, manually ported from Coffee to JS. [ATTN: backbone.JJRelational.js.map not updated/out-of-sync]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug when calling Collection#set with an array of ids, taking only first id.
[Consider merging only d392bb5, (discarding 6a872da) and compiling JS and JS.map of your own.]