Open
Conversation
…re-nlp as an explicit dependency.
Author
|
As an update I was wrong about this being sufficient to make this usable via maven in other projects- the pom.xml file as it currently stands also has a few other issues that are beyond my abilities/knowledge to fix, but this PR does seem to be a necessary step along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating pom.xml to explicitly include core-nlp as a dependency and to also be pulling in an extant version of fastner. All tests still pass, so this didn't break anything, and now this ought to be usable via maven as normal.