Skip to content

⚡ perf: remove unnecessary SKShapeNode allocation#4

Open
jhurt wants to merge 1 commit into
masterfrom
perf/remove-unused-node-allocation-2944114691005413024
Open

⚡ perf: remove unnecessary SKShapeNode allocation#4
jhurt wants to merge 1 commit into
masterfrom
perf/remove-unused-node-allocation-2944114691005413024

Conversation

@jhurt

@jhurt jhurt commented Jun 6, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced the explicit allocation of unusedCircleNode with mathematically derived dimensions (radius * 2.0) to calculate pageIndicatorWidth and pageIndicatorHeight in addIndicator().

🎯 Why: Creating a throwaway SKShapeNode simply to determine its resulting frame dimensions adds unnecessary overhead (CPU, memory allocation) during indicator setup.

📊 Measured Improvement: The swift and xcodebuild environments are unavailable to measure baseline and post-change performance. However, removing an unneeded object allocation inherently provides a net reduction in UI overhead by avoiding the initialization cost and garbage collection / reference counting overhead associated with SKShapeNode.


PR created automatically by Jules for task 2944114691005413024 started by @jhurt

Replaced explicit allocation of `unusedCircleNode` with direct mathematical calculation (`radius * 2.0`) to avoid unnecessary object allocation and improve performance.

Co-authored-by: jhurt <86135+jhurt@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant