Do not set the globally installed Drush as default binary path#664
Closed
mxr576 wants to merge 1 commit intojhedstrom:mainfrom
Closed
Do not set the globally installed Drush as default binary path#664mxr576 wants to merge 1 commit intojhedstrom:mainfrom
mxr576 wants to merge 1 commit intojhedstrom:mainfrom
Conversation
AlexSkrypnyk
requested changes
Dec 23, 2025
| $container->setParameter('drupal.driver.drush.alias', $config['drush']['alias']); | ||
|
|
||
| $config['drush']['binary'] = isset($config['drush']['binary']) ? $config['drush']['binary'] : 'drush'; | ||
| $config['drush']['binary'] = isset($config['drush']['binary']) ? $config['drush']['binary'] : ''; |
Collaborator
There was a problem hiding this comment.
I think this should throw a RuntimeException if the binary path is not set. alternatively, it may default to vendor/bin/drush. But leaving this empty could trigger a cascade of issues that will be hard to debug.
Collaborator
|
Hey @mxr576 — thanks for raising this. You were right that defaulting to a global I've opened #799 which takes a slightly different approach — defaulting to Closing this one in favour of that approach. Appreciate you flagging it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra handling in connection with jhedstrom/DrupalDriver#272 and the proposed change in jhedstrom/DrupalDriver#273.